Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(request): enable requests to be awaited upon #483

Merged
merged 2 commits into from
Jul 6, 2023

Conversation

JasonBerry
Copy link
Collaborator

This will enable being able to await on events being sent.

@JasonBerry JasonBerry requested review from wwalser and benhinchley July 4, 2023 07:37
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 4, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a899fd7:

Sandbox Source
Vanilla Configuration

@wwalser
Copy link

wwalser commented Jul 5, 2023

My initial intuition was that we should provide the conventional Node interface and offer the ability to pass a callback but that would break the strict polymorphic type cohesion between node and browser versions of the library.

This looks correct. Have you manually tested that the code form the ticket executes as expected now? https://algolia.atlassian.net/browse/CR-3696?focusedCommentId=316055

@wwalser wwalser requested review from Haroenv and wwalser and removed request for wwalser July 5, 2023 04:55
Copy link

@wwalser wwalser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JasonBerry
Copy link
Collaborator Author

Have you manually tested that the code form the ticket executes as expected now?
I eyeballed the code from the ticket and it looks fine, but it just really irked me that there was no way for customers to write something effective using our insights library and we can do better.

@JasonBerry JasonBerry merged commit 1d0cb09 into main Jul 6, 2023
@JasonBerry JasonBerry deleted the enable-request-awaiting branch July 6, 2023 00:41
JasonBerry added a commit that referenced this pull request Jul 7, 2023
This will enable being able to `await` on events being sent.
JasonBerry added a commit that referenced this pull request Jul 7, 2023
This will enable being able to `await` on events being sent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants