Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove engines config from package.json #496

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

benhinchley
Copy link
Member

This config is a warning at best and only enforced if https://docs.npmjs.com/cli/v9/using-npm/config#engine-strict is set.

Our node version requirements are for building and testing the package, rather than actually running the code.

CR-4263

This config is a warning at best and only enforced if https://docs.npmjs.com/cli/v9/using-npm/config#engine-strict is set.

Our node version requirements are for building and testing the package, rather than actually running the code.
@benhinchley benhinchley requested a review from a team as a code owner September 1, 2023 00:15
@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 1, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 05b7504:

Sandbox Source
Vanilla Configuration

@benhinchley benhinchley enabled auto-merge (squash) September 1, 2023 00:29
@benhinchley benhinchley merged commit 0bef4a5 into main Sep 1, 2023
@benhinchley benhinchley deleted the CR-4263/drop-node-version-marker branch September 1, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants