fix(timestamp): make timestamp optional #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkrugg
requested review from
samouss,
Haroenv,
francoischalifour and
JonasBa
tkrugg
force-pushed
the
v2/timestamp-optional
branch
from
3d19e92 to
d6d2109
Compare
tkrugg
changed the title
samouss
approved these changes
Dec 12, 2018
tkrugg
force-pushed
the
v2/timestamp-optional
branch
from
008a253 to
46c6f0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a port of the fix that was made on 0.0.15.
It aims to allow the user not to send a timestamp in order to use the server-side generated timestamp.
User can still override the timestamp if wanted
fixes #46
fixes #32