Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: expose purchase and addToCart insights client methods #511

Merged
merged 2 commits into from
Sep 25, 2023
Merged

fix: expose purchase and addToCart insights client methods #511

merged 2 commits into from
Sep 25, 2023

Conversation

jkaho
Copy link
Contributor

@jkaho jkaho commented Sep 21, 2023 •
edited by jira bot
Loading

The purchasedObjectIDs, purchasedObjectIDsAfterSearch, addedToCartObjectIDs, and addedToCartObjectIDsAfterSearch methods were added recently, but haven't been made accessible via the Insights client.

Also add the missing currency attribute to the conversion event types.

EEX-737

@jkaho jkaho requested a review from a team as a code owner September 21, 2023 23:11
@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 21, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 38a4780:

Sandbox Source
Vanilla Configuration

@soulplant soulplant changed the title fix: expose purchase and addToCard insights client methods fix: expose purchase and addToCart insights client methods Sep 22, 2023
soulplant
soulplant reviewed Sep 22, 2023
View reviewed changes
Copy link

@soulplant soulplant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any tests we should update?

soulplant
soulplant approved these changes Sep 22, 2023
View reviewed changes
Copy link

@soulplant soulplant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks, Jess 🙂

@jkaho
Copy link
Contributor Author

jkaho commented Sep 22, 2023 •
edited
Loading

@soulplant related question - should the top-level queryID for the purchase and addToCart events be optional?

@soulplant
Copy link

soulplant commented Sep 22, 2023 •
edited by jkaho
Loading

@soulplant related question - should the top-level queryID for the purchase and addToCart events be optional?

Good question! I'd say

  • sendEvents: optional
  • purchasedObjectIDs: optional
  • purchasedObjectIDsAfterSearch: required

and likewise for addToCart methods.

@jkaho jkaho merged commit 6c3a322 into main Sep 25, 2023
@jkaho jkaho deleted the EEX-737/add-missing-purchase-and-add-to-cart-client-methods branch September 25, 2023 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soulplant soulplant soulplant approved these changes

@JasonBerry JasonBerry JasonBerry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkaho @soulplant @JasonBerry