Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add query id inference for conversion events based on prior clicks #534

Merged
merged 2 commits into from
Jul 3, 2024
Merged

feat: add query id inference for conversion events based on prior clicks #534

merged 2 commits into from
Jul 3, 2024

Conversation

JasonBerry
Copy link
Collaborator

This is the majority of the inference logic. A couple of things not added yet:

  • when eventSubtype is addToCart store any queryID passed for future purchase conversion events
  • removal of objectID/queryID association from store when eventSubtype is purchase
  • pruning of associations older than 90 days

@JasonBerry JasonBerry requested a review from a team as a code owner June 25, 2024 08:39
@codesandbox-ci CodeSandbox CI
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

jkaho
jkaho reviewed Jun 26, 2024
View reviewed changes
@JasonBerry JasonBerry merged commit ca2f234 into main Jul 3, 2024
4 checks passed
@JasonBerry JasonBerry deleted the EEX-1216/query-id-tracking branch July 3, 2024 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkaho jkaho jkaho approved these changes

@jonathaningram jonathaningram Awaiting requested review from jonathaningram

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JasonBerry @jkaho