feat(cookieDuration): add cookieDuration support #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkrugg
changed the title
tkrugg
changed the title
tkrugg
force-pushed
the
feat/cookie-duration
branch
from
2660d1f to
044069d
Compare
tkrugg
commented
Dec 14, 2018
| const credentials = { | ||
| apiKey: "test", | ||
| applicationID: "test" | ||
| }; |
There was a problem hiding this comment.
was unsused.
I will check tslint config to make sure this doesn't occur more: #62
|
|
||
| /** |
There was a problem hiding this comment.
I moved createUUID outside so I can mock it in the tests. It's generic enough that it can belong inside utils/index.ts
|
|
||
| const cookieDuration = options.cookieDuration | ||
| ? options.cookieDuration | ||
| : 6 * MONTH; |
There was a problem hiding this comment.
by default cookieDuration is 6 months
|
|
||
| describe("createUUID", () => { | ||
| it("should return a string composed of valid hex characters or dashes `-`", () => { | ||
| expect(createUUID()).toMatch(/^[0-9a-f\-]+$/); |
There was a problem hiding this comment.
No need to test this more. We don't actually care that this is a valid uuid. What's important is that:
- it's random
- it contains only hex characters so that they don't get encoded when used in a cookie.
tkrugg
changed the title
tkrugg
force-pushed
the
feat/cookie-duration
branch
from
044069d to
4368c2f
Compare
- remove cookie reuinitialization at each init - move createUUID outside cookie methods for easier testing - add tests for createUUID
tkrugg
force-pushed
the
feat/cookie-duration
branch
from
4368c2f to
babb1ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: