Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Method object in ABI Results returned from execute call of ATC #183

Closed
barnjamin opened this issue Jun 3, 2022 · 3 comments
Closed
Labels
new-feature-request Feature request that needs triage

Comments

@barnjamin
Copy link
Contributor

Problem

I'd like to have access to the method called for a given ABIResult object

Solution

Add Method to ABIResult object in all SDKs

algorand/py-algorand-sdk#342
algorand/go-algorand-sdk#329
algorand/js-algorand-sdk#578
algorand/java-algorand-sdk#334

@jasonpaulos
Copy link
Contributor

Those PRs look good, but I'll add this optional suggestion as well:

We have a cucumber step to check the return value of methods:

And The app should have returned "<returns>".

Right now each SDK implements this by keeping a separate list of methods that were registered with the atomic transaction composer:

You could remove these lists and now use the new method field directly on the ABI results value. This would clean up the testing code a little and lend some coverage to the new field.

@barnjamin
Copy link
Contributor Author

Updated the PRs to use the method from the ABI result, waiting for CI

@barnjamin
Copy link
Contributor Author

These PRs have all been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature-request Feature request that needs triage
Projects
None yet
Development

No branches or pull requests

2 participants