Generate updated API client code #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algoidurovic
force-pushed
the
generate_api
branch
from
d1828ae to
742dbfc
Compare
jasonpaulos
reviewed
May 11, 2022
This was referenced May 13, 2022
winder
reviewed
May 26, 2022
client/v2/algod/tealDisassemble.go
Outdated
|
|
||
| // Do performs the HTTP request | ||
| func (s *TealDisassemble) Do(ctx context.Context, headers ...*common.Header) (response models.DisassembleResponse, err error) { | ||
| err = s.c.get(ctx, &response, "/v2/teal/disassemble", nil, headers) |
There was a problem hiding this comment.
According to the link jason shared, shouldn't this be a POST and include the bytes body?
https://github.com/algorand/go-algorand/blob/aa82b9a6e78dd38c8115120ca90b817f6be73ef3/daemon/algod/api/algod.oas2.json#L1441
There was a problem hiding this comment.
Sorry, this is a stale change. I pulled develop into this branch and now it's gone.
…into generate_api
michaeldiamant
approved these changes
May 26, 2022
jasonpaulos
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: algorand/go-algorand#3957