Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestTransactionPoolOrderingAndClearing needs to be fixed and enabled #2323

Closed
algonautshant opened this issue Jun 23, 2021 · 1 comment
Closed

Comments

@algonautshant
Copy link
Contributor

algonautshant commented Jun 23, 2021

Summary

test/e2e-go/features/transactions/transactionPool_test.go-func TestTransactionPoolOrderingAndClearing(t *testing.T) {
test/e2e-go/features/transactions/transactionPool_test.go: t.Skip("test is flaky as of 2019-06-18")
This was disabled long time ago #45
Now never passes.

The tests stops one of the nodes, and expects the other node not to make any progress. However, the node continues to make progress.
This is not the main reason why the test is failing, but contributes to the stability of the test.
The other issue is that the test is expecting the transactions to be ordered by the fee, but they are not.

Similar issues are the following that need attention:
Those may need to be conditioned based on the protocol version.

test/e2e-go/features/transactions/transactionPool_test.go-func TestTransactionPoolExponentialFees(t *testing.T) {
test/e2e-go/features/transactions/transactionPool_test.go: t.Skip("new FIFO pool does not have exponential fee txn replacement")

test/e2e-go/restAPI/restClient_test.go-func TestClientPrioritizesPendingTransactions(t *testing.T) {
test/e2e-go/restAPI/restClient_test.go: t.Skip("new FIFO pool does not have prioritization")

Scope/Requirements

Fix the test and enable it.

Urgency/Relative Priority

This is not urgent, since it was disabled long time ago.
But it is important to fix it soon, otherwise the test will drift further away from the code.

@algonautshant
Copy link
Contributor Author

This test was removed here: #2557

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant