You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This deserves fixing, but another problem probably can't be fixed - In the face of arbitrary conditional code, and the presence of multiple non-deadcode cblocks, the disassembler should know that it might be confused and probably stop spitting out the comments at all.
Problem
The disassembler makes a best-effort attempt to annotate
intc
references with the associated literal value to improve human readability.Since the disassembler is not dead code aware, it leads to annotated comments that are obviously wrong. Consider the following snippet:
As of #4442, the output incorrectly shows
intc_0 // 10
instead ofintc_0 // 1
:A direct response to the problem at-hand is to extend the disassembler to account for dead code, which fixes the example's comments.
Additionally, it may make sense to consider if there are more general rules / changes to consider for disassembly.
Solution
Dependencies
Urgency
The text was updated successfully, but these errors were encountered: