Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

algod API: Remove errant base64 docs reference #3982

Merged

Conversation

michaeldiamant
Copy link
Contributor

Removes an errant base64 docs reference introduced in #3908 that was noticed in algorand/go-algorand-sdk#316 (comment).

@michaeldiamant
Copy link
Contributor Author

Forgot to mention in description - Generated diffs created via make -C daemon/algod/api/ generate.

Copy link
Contributor

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good

@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #3982 (36746fa) into master (aa82b9a) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3982      +/-   ##
==========================================
+ Coverage   49.76%   49.78%   +0.01%     
==========================================
  Files         409      409              
  Lines       69157    69157              
==========================================
+ Hits        34419    34431      +12     
+ Misses      31014    31005       -9     
+ Partials     3724     3721       -3     
Impacted Files Coverage Δ
ledger/roundlru.go 90.56% <0.00%> (-5.67%) ⬇️
cmd/algoh/blockWatcher.go 77.77% <0.00%> (-3.18%) ⬇️
ledger/tracker.go 70.56% <0.00%> (-2.60%) ⬇️
data/transactions/verify/txn.go 44.15% <0.00%> (-0.87%) ⬇️
network/wsNetwork.go 62.99% <0.00%> (+0.19%) ⬆️
cmd/tealdbg/debugger.go 73.49% <0.00%> (+0.80%) ⬆️
catchup/service.go 70.12% <0.00%> (+1.23%) ⬆️
crypto/merkletrie/node.go 93.48% <0.00%> (+1.86%) ⬆️
crypto/merkletrie/trie.go 68.61% <0.00%> (+2.18%) ⬆️
util/metrics/counter.go 88.50% <0.00%> (+2.29%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa82b9a...36746fa. Read the comment docs.

Copy link
Contributor

@algochoi algochoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants