fix(Menu): string in Group/SubMenu causes error, close #952

alibaba-fusion · Aug 7, 2019 · 18a7f17 · 18a7f17
1 parent 67f0d49
commit 18a7f17
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/src/menu/view/group.jsx b/src/menu/view/group.jsx
@@ -41,6 +41,10 @@ export default class Group extends Component {
         });
 
         const newChildren = children.map(child => {
+            // to fix https://github.com/alibaba-fusion/next/issues/952
+            if (typeof child !== 'function' && typeof child !== 'object') {
+                return child;
+            }
             const { className } = child.props;
             const newChildClassName = cx({
                 [`${prefix}menu-group-item`]: true,

diff --git a/src/menu/view/sub-menu.jsx b/src/menu/view/sub-menu.jsx
@@ -119,6 +119,11 @@ export default class SubMenu extends Component {
         const { mode, root } = this.props;
 
         return Children.map(children, child => {
+            // to fix https://github.com/alibaba-fusion/next/issues/952
+            if (typeof child !== 'function' && typeof child !== 'object') {
+                return child;
+            }
+
             return cloneElement(child, {
                 parent: this,
                 parentMode: mode || root.props.mode,