fix(Range): Prevent right-button dragging

alibaba-fusion · Nov 13, 2018 · 24b6769 · 24b6769
1 parent 04f9466
commit 24b6769
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 11 deletions.
diff --git a/src/range/view/range.jsx b/src/range/view/range.jsx
@@ -343,12 +343,14 @@ export default class Range extends React.Component {
     }
 
     _onMouseDown(e) {
-        this.setState({
-            hasMovingClass: true
-        });
-        this._start(e.pageX);
-        this._addDocumentEvents();
-        pauseEvent(e);
+        if(e.button === 0) {
+            this.setState({
+                hasMovingClass: true
+            });
+            this._start(e.pageX);
+            this._addDocumentEvents();
+            pauseEvent(e);
+        }
     }
 
     _start(position) {

diff --git a/test/range/index-spec.js b/test/range/index-spec.js
@@ -173,7 +173,7 @@ describe('Range ', () => {
         </Range>);
 
         const RangeInstance = wrapper.find('Range').at(0).instance();
-        RangeInstance._onMouseDown({pageX: 10, stopPropagation: () => {}, preventDefault: () => {} });
+        RangeInstance._onMouseDown({button: 0, pageX: 10, stopPropagation: () => {}, preventDefault: () => {} });
         RangeInstance._move({pageX: 20, stopPropagation: () => {}, preventDefault: () => {}});
         RangeInstance._end();
 
@@ -204,14 +204,14 @@ describe('Range ', () => {
         </Range>);
 
         const RangeInstance = wrapper.find('Range').at(0).instance();
-        RangeInstance._onMouseDown({pageX: 10, stopPropagation: () => {}, preventDefault: () => {} });
+        RangeInstance._onMouseDown({button: 0, pageX: 10, stopPropagation: () => {}, preventDefault: () => {} });
         RangeInstance._move({pageX: 30, stopPropagation: () => {}, preventDefault: () => {}});
         RangeInstance._end();
 
         assert(changeValue[0] === 20);
         assert(changeValue[1] === 30);
 
-        RangeInstance._onMouseDown({pageX: 30, stopPropagation: () => {}, preventDefault: () => {} });
+        RangeInstance._onMouseDown({button: 0, pageX: 30, stopPropagation: () => {}, preventDefault: () => {} });
         RangeInstance._move({pageX: 0, stopPropagation: () => {}, preventDefault: () => {}});
         RangeInstance._end();
 
@@ -275,7 +275,7 @@ describe('Range ', () => {
 
         const RangeInstance = wrapper.find('Range').at(0).instance();
 
-        RangeInstance._onMouseDown({pageX: 10, stopPropagation: () => {}, preventDefault: () => {} });
+        RangeInstance._onMouseDown({button: 0, pageX: 10, stopPropagation: () => {}, preventDefault: () => {} });
         assert(RangeInstance.dom.querySelector('.next-range-active') !== null);
     });
 
@@ -293,7 +293,7 @@ describe('Range ', () => {
 
         assert(document.querySelector('.next-balloon-tooltip') === null);
         // wrapper.find('.next-range-frag').simulate('mousedown');
-        ReactTestUtils.Simulate.mouseDown(document.querySelectorAll('.next-range-frag')[0]);
+        ReactTestUtils.Simulate.mouseDown(document.querySelectorAll('.next-range-frag')[0], {button: 0});
         assert(document.querySelector('.next-balloon-tooltip') !== null);
         simulateEvent.simulate(document, 'mouseup');