fix(Menu): fix hozInLine mode popup bug when subMenu has a specified key, close #4222 #4226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
test 失败了，但是看失败结果，好像和 pr 的组件无关，感觉可能是偶发性的。 |
Codecov ReportBase: 90.58% // Head: 90.58% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4226 +/- ##
==========================================
- Coverage 90.58% 90.58% -0.01%
==========================================
Files 305 305
Lines 17944 17943 -1
Branches 5525 5524 -1
==========================================
- Hits 16254 16253 -1
Misses 1669 1669
Partials 21 21
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
lakerswgq
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这样的改动在试了几个方案后改动最小，被折叠的 item 主要用途是计算宽度，不需要拿真实的 key导致计算时 p2n 和 k2n 被重复计算，且位置错误。