New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mis-accumulated momentum #450

Closed

joneswong opened this issue Dec 5, 2022 · 1 comment · Fixed by #451

Assignees

Labels

bug

Collaborator

joneswong commented Dec 5, 2022

FederatedScope/federatedscope/contrib/trainer/torch_example.py

Line 27 in 6d2c14c

self.optimizer = torch.optim.SGD(self.model.parameters(),

It seems that once the optimizer is constructed, it works through the whole training course.

joneswong added the bug label

joneswong assigned rayrayraykk

Collaborator

rayrayraykk commented Dec 5, 2022 •

edited

Loading

OK, I will fix this.

rayrayraykk linked a pull request

that will close this issue

Fix torch trainer example #451

Merged

xieyxclack closed this as completed in #451

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment