bugfix: specify both cmd and its args when create a container #1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaoZengzeng
force-pushed
the
projected
branch
2 times, most recently
from
bb1d7b1 to
9982898
Compare
Codecov Report
@@ Coverage Diff @@
## master #1027 +/- ##
=======================================
Coverage 14.21% 14.21%
=======================================
Files 127 127
Lines 8474 8474
=======================================
Hits 1205 1205
Misses 7169 7169
Partials 100 100
Continue to review full report at Codecov.
|
YaoZengzeng
changed the title
|
Please provide more details about this pull request in pull request description. @YaoZengzeng |
|
@allencloud PTAL |
YaoZengzeng
force-pushed
the
projected
branch
3 times, most recently
from
5adc900 to
9f714fd
Compare
Signed-off-by: YaoZengzeng <[email protected]>
|
With this PR, the node-e2e test result will be: Ran 186 of 258 Specs in 1501.814 seconds exciting 😄 |
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: YaoZengzeng [email protected]
Ⅰ. Describe what this PR did
Actually I forget to specify the args of the cmd executed in the container, so fill it in this PR.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews