Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test:add container get test #1037

Merged
merged 1 commit into from
Apr 3, 2018

Conversation

Dewey-Ding
Copy link
Contributor

Signed-off-by: Dewey-Ding [email protected]

Ⅰ. Describe what this PR did

add container get test

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

Codecov Report

Merging #1037 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1037      +/-   ##
==========================================
+ Coverage   15.18%   15.27%   +0.09%     
==========================================
  Files         135      136       +1     
  Lines        8483     8483              
==========================================
+ Hits         1288     1296       +8     
+ Misses       7094     7086       -8     
  Partials      101      101
Impacted Files Coverage Δ
client/container.go 0% <ø> (ø) ⬆️
client/container_get.go 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85d808d...0dfe9ee. Read the comment docs.

@pouchrobot
Copy link
Collaborator

ping @Dewey-Ding

CI fails according integration system.
Please refer to the CI failure Details button to corresponding test, and update your PR to pass CI.

If this is flaky test, welcome to track this with profiling an issue.

build url: https://travis-ci.org/alibaba/pouch/builds/361213157
build duration: 1639s

@allencloud
Copy link
Collaborator

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Apr 3, 2018
@allencloud allencloud merged commit 48bb847 into AliyunContainerService:master Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/test LGTM one maintainer or community participant agrees to merge the pull reuqest. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants