-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: upgrade containerd version to v1.0.3 #1148
feature: upgrade containerd version to v1.0.3 #1148
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1148 +/- ##
==========================================
- Coverage 16.03% 15.32% -0.71%
==========================================
Files 173 173
Lines 9904 9779 -125
==========================================
- Hits 1588 1499 -89
+ Misses 8200 8172 -28
+ Partials 116 108 -8
|
Please help to review if the containerd 1.0.3 would influence the current pouchd. @HusterWan In addition, please help review the installation part to check if more improvement in the package building is needed. @Letty5411 |
@@ -48,10 +48,12 @@ | |||
"revisionTime": "2017-09-25T15:48:32Z" | |||
}, | |||
{ | |||
"checksumSHA1": "3tWZA853zC/N1yoGDEkkye76Vv0=", | |||
"checksumSHA1": "1ny6UV3Oq4kaqpQtM8bs9W9e3vw=", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am afraid that beside this package github.com/containerd/containerd
we still have some sub packages in vendor.json, such as github.com/containerd/containerd/api/services/containers/v1
, github.com/containerd/containerd/api/services/content/v1
.
I have two parts to confirm:
- Do we still need all the sub packages?
- If the above answer is yes, do we need to make all sub packages and containerd package with the same version
v1.0.3
?
Seems to have discussion offline with @rudyfly , please add some comment if you have any thoughts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I will check the sub-packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@allencloud and @rudyfly
I use govendor fetch github.com/containerd/containerd/[email protected]
to fetch the v1.0.3. But this command will import the github.com/Microsoft/go-winio
package in the vendor. Since we have the package in the libnetwork/Godeps
, in order to keep the consistent, I decided to remove the package after update command govendor fetch github.com/containerd/containerd/[email protected]
.
If you have any questions, please add the comment. Thanks
@fuweid the following script also need to be updated, they are used to build package:
|
Not just vendor, but also update the docs. fix #1141 Signed-off-by: Wei Fu <[email protected]>
@Letty5411 I have updated based on your comment. Please help me to check. Thanks |
LGTM |
containerd/containerd#2186, i think upgraded containerd should contain this pr, @fuweid @allencloud WDYT? |
Hi @HusterWan , could you help us to verify the "hang" case in pouch? |
@HusterWan Actually I am not the side of using a non-released version of containerd, although the non-release version covered the grpc-go bug you mentioned. |
LGTM |
Ⅰ. Describe what this PR did
Upgrade containerd to make the pouchd stable.
The version of containerd will be changed from v1.0.0 to v1.0.3
Ⅱ. Does this pull request fix one issue?
fixes #1141
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
It's the dependency upgrade. I have tested
pouch run -it busybox /bin/sh
in local and it passed.It should be covered by CI.
Ⅴ. Special notes for reviews
NONE