Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix ci fail cause container run and stop #1214

Merged
merged 1 commit into from
Apr 25, 2018
Merged

test: fix ci fail cause container run and stop #1214

merged 1 commit into from
Apr 25, 2018

Conversation

Ace-Tang
Copy link
Contributor

Signed-off-by: Ace-Tang [email protected]

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@Ace-Tang
Copy link
Contributor Author

fix ci fail

AIL: /go/src/github.com/alibaba/pouch/test/cli_update_test.go:228: PouchUpdateSuite.TestUpdateContainerLabel
/go/src/github.com/alibaba/pouch/test/cli_update_test.go:233:
    command.PouchRun("update", "--label", "foo=bar", name).Assert(c, icmd.Success)
/go/src/github.com/alibaba/pouch/vendor/github.com/gotestyourself/gotestyourself/icmd/command.go:61:
    t.Fatalf("at %s:%d - %s\n", filepath.Base(file), line, err.Error())
... Error: at cli_update_test.go:233 - 
Command:  /usr/local/bin/pouch update --label foo=bar update-container-label
ExitCode: 1
Error:    exit status 1
Stdout:   
Stderr:   Error: {"message":"task 1fa9f4a80f39c6441bee5bc047676e1f74bc58babaf5ded820bcbb7bd60859db not found: not found"}
Failures:
ExitCode was 1 expected 0
Expected no error

@codecov-io
Copy link

Codecov Report

Merging #1214 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1214   +/-   ##
=======================================
  Coverage   15.66%   15.66%           
=======================================
  Files         171      171           
  Lines       10393    10393           
=======================================
  Hits         1628     1628           
  Misses       8645     8645           
  Partials      120      120

@HusterWan
Copy link
Contributor

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Apr 25, 2018
@HusterWan HusterWan merged commit 5c5d937 into AliyunContainerService:master Apr 25, 2018
@Ace-Tang Ace-Tang deleted the fix-container-stop branch April 25, 2018 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/test LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants