Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: better arch to add connection between cri manager and pouchd #1465

Merged
merged 1 commit into from
Jun 5, 2018

Conversation

allencloud
Copy link
Collaborator

Signed-off-by: Allen Sun [email protected]

Ⅰ. Describe what this PR did

After discussing with @fanux about the architecture of PouchContainer, we found that we should add a connection between pouchd and cri-manager, and this will tell users that with using Kubernetes, pouchcontainer can still provide containers with powerful runtime support, like lxcfs and diskquota and so on.

Ⅱ. Does this pull request fix one issue?

none

Ⅲ. Describe how you did it

none

Ⅳ. Describe how to verify it

none

Ⅴ. Special notes for reviews

none

@codecov-io
Copy link

codecov-io commented Jun 4, 2018

Codecov Report

Merging #1465 into master will increase coverage by 23.71%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1465       +/-   ##
===========================================
+ Coverage   16.36%   40.08%   +23.71%     
===========================================
  Files         207      250       +43     
  Lines       13816    16351     +2535     
===========================================
+ Hits         2261     6554     +4293     
+ Misses      11399     8952     -2447     
- Partials      156      845      +689
Impacted Files Coverage Δ
daemon/logger/jsonfile/utils.go 70% <0%> (ø) ⬆️
storage/volume/modules/local/local.go 70.68% <0%> (ø)
lxcfs/lxcfs.go 55.55% <0%> (ø)
cri/stream/httpstream/httpstream.go 0% <0%> (ø)
apis/metrics/metrics.go 100% <0%> (ø)
cri/stream/remotecommand/websocket.go 0% <0%> (ø)
registry/auth.go 54.12% <0%> (ø)
storage/quota/grpquota.go 0% <0%> (ø)
network/mode/bridge/bridge.go 67.74% <0%> (ø)
cri/stream/remotecommand/exec.go 0% <0%> (ø)
... and 111 more

@allencloud
Copy link
Collaborator Author

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Jun 5, 2018
@allencloud allencloud merged commit 9de6fb6 into AliyunContainerService:master Jun 5, 2018
@allencloud allencloud deleted the better-arch branch June 5, 2018 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/docs LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants