Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update INSTALLATION.md #1698

Merged
merged 1 commit into from
Jul 12, 2018
Merged

Conversation

wq2625
Copy link
Contributor

@wq2625 wq2625 commented Jul 10, 2018

LXCFS is a simple userspace filesystem designed to work around some current limitations of the Linux kernel.
So we modify 'lxcfs' to 'LXCFS' to avoid confusion.

LXCFS is a simple userspace filesystem designed to work around some current limitations of the Linux kernel.
So we modify 'lxcfs' to 'LXCFS' to avoid confusion.
@pouchrobot
Copy link
Collaborator

@wq2526 Thanks for your contribution. 🍻
Please sign off in each of your commits.

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @wq2526
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@CLAassistant
Copy link

CLAassistant commented Jul 10, 2018

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

codecov-io commented Jul 10, 2018

Codecov Report

Merging #1698 into master will decrease coverage by 23.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1698       +/-   ##
===========================================
- Coverage   41.16%   18.13%   -23.03%     
===========================================
  Files         274      228       -46     
  Lines       18091    15271     -2820     
===========================================
- Hits         7447     2770     -4677     
- Misses       9729    12307     +2578     
+ Partials      915      194      -721
Impacted Files Coverage Δ
pkg/httputils/http_utils.go 0% <0%> (-100%) ⬇️
pkg/httputils/http_error.go 0% <0%> (-100%) ⬇️
apis/server/router.go 0% <0%> (-91.37%) ⬇️
daemon/mgr/container_state.go 0% <0%> (-87.24%) ⬇️
apis/server/volume_bridge.go 0% <0%> (-86.67%) ⬇️
daemon/containerio/hijack_conn.go 2.85% <0%> (-85.72%) ⬇️
daemon/mgr/container_monitor.go 0% <0%> (-85.19%) ⬇️
daemon/mgr/container_logger.go 0% <0%> (-84%) ⬇️
daemon/mgr/spec_annotations.go 0% <0%> (-82.36%) ⬇️
apis/server/container_bridge.go 0% <0%> (-82.02%) ⬇️
... and 130 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3c247c...474a06b. Read the comment docs.

@allencloud
Copy link
Collaborator

LGTM

@allencloud allencloud merged commit c83d94f into AliyunContainerService:master Jul 12, 2018
@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants