-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: set lxcfs managed by systemd #885
refactor: set lxcfs managed by systemd #885
Conversation
Codecov Report
@@ Coverage Diff @@
## master #885 +/- ##
==========================================
- Coverage 14.62% 14.58% -0.04%
==========================================
Files 115 116 +1
Lines 6940 6958 +18
==========================================
Hits 1015 1015
- Misses 5839 5857 +18
Partials 86 86
Continue to review full report at Codecov.
|
|
@@ -10,6 +10,7 @@ KillMode=process | |||
Restart=on-failure | |||
ExecStopPost=-/usr/bin/fusermount -u /var/lib/lxcfs | |||
Delegate=yes | |||
ExecStartPost=pouch remount-lxcfs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also need to change ./package/deb/systemd/pouch.service
Signed-off-by: codejuan <[email protected]>
e9f5177
to
8c0c289
Compare
LGTM |
@Letty5411 I modify the service file like you do, but after restarting lxcfs, still can't see the file /proc/meminfo in the container. This error still exists. “cat: /proc/meminfo: Transport endpoint is not connected” |
The same problem. After starting the lxcfs service,Execute the following mount command: in container:
@CodeJuan @Letty5411 Please help😁 |
Ⅰ. Describe what this PR did
To improve availability, lxcfs process should be managed by other process, such as systemd.
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
/var/lib/lxcfs
pouchd --enable-lxcfs
pouch run -m 512M --enableLxcfs=true registry.hub.docker.com/library/busybox:latest head -n 1 /proc/meminfo
524288 kB
Ⅴ. Special notes for reviews