feature: sandbox store for cri manager #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaoZengzeng
force-pushed
the
sandbox-store
branch
from
a133d6b to
3aaf7fa
Compare
Signed-off-by: YaoZengzeng <[email protected]>
YaoZengzeng
force-pushed
the
sandbox-store
branch
from
3aaf7fa to
b1bb9b1
Compare
Codecov Report
@@ Coverage Diff @@
## master #955 +/- ##
=========================================
- Coverage 13.12% 13.1% -0.03%
=========================================
Files 123 123
Lines 8197 8213 +16
=========================================
Hits 1076 1076
- Misses 7025 7041 +16
Partials 96 96
Continue to review full report at Codecov.
|
|
@allencloud PTAL. |
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: YaoZengzeng [email protected]
Ⅰ. Describe what this PR did
We should store the config of sandbox in cri manager.
Because we need some of them when stop or remove the pod and we couldn't get it directly from API.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews