Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImageMatching broken on develop branch #1279

Closed
fabiencastan opened this issue Oct 10, 2022 · 2 comments · Fixed by #1280
Closed

ImageMatching broken on develop branch #1279

fabiencastan opened this issue Oct 10, 2022 · 2 comments · Fixed by #1280

Comments

@fabiencastan
Copy link
Member

"imageMatches.txt" is exported in json (instead of one line per image) and not read as json, so the default pipeline is unusable.

@p12tic Any idea how this has been introduced?
@fabiencastan
Copy link
Member Author

Probably here:
https://github.com/alicevision/AliceVision/pull/1270/files#diff-539dbd36c413011ccb9cd64d14d45e29b90268f1f585ce6f031f472581fa4eceL88
the override of the formatting has been removed and there is maybe a default one for std containers.

@p12tic
Copy link
Contributor

p12tic commented Oct 10, 2022

@fabiencastan Looking

@fabiencastan fabiencastan mentioned this issue Oct 10, 2022
Merged
@p12tic p12tic mentioned this issue Oct 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[imageMatching] bug fix: file format exporter alicevision/AliceVision
2 participants
@fabiencastan @p12tic