Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support keyDecodingStrategy property for snake case field names #34

Open
phatmann opened this issue Apr 13, 2018 · 4 comments
Open

Support keyDecodingStrategy property for snake case field names #34

phatmann opened this issue Apr 13, 2018 · 4 comments

Comments

@phatmann
Copy link

Same idea as keyDecodingStrategy in JSONDecoder. Would let us use snake_case, a very common Firebase idiom.
@alickbass
Copy link
Owner

Hi! Thanks for your feedback! I definitely think that we should consider implementing it as a part of the library

@phatmann
Copy link
Author

phatmann commented Apr 30, 2018 •
edited
Loading

KeyDecodingStrategy enum from JSONEncoder. Includes string conversion method, unfortunately private. And here is the relevant mapping code.

@alickbass
Copy link
Owner

@phatmann do you want to submit a PR for this feature?

@phatmann
Copy link
Author

phatmann commented Oct 6, 2018

@alickbass I see you have PR to merge your code into the Firebase SDK: firebase/firebase-ios-sdk#838. Any progress on that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phatmann @alickbass