Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(contribution-types): added "Data" contribution #231

Merged
merged 4 commits into from
Jan 3, 2020
Merged

feat(contribution-types): added "Data" contribution #231

merged 4 commits into from
Jan 3, 2020

Conversation

smoia
Copy link
Contributor

@smoia smoia commented Dec 2, 2019 •
edited
Loading

What:
Implements the "Data" category from all-contributors/all-contributors#336

Why:
Cf. all-contributors/all-contributors#334

How:
Used #176 as a blueprint

Checklist:

  • Documentation
  • Tests
  • Ready to be merged
  • Added myself to contributors table

@smoia
Copy link
Contributor Author

smoia commented Dec 2, 2019

I saw that the latest PRs have all validation issues - is it ok or should I change something?

@Berkmann18
Copy link
Member

@smoia You indeed to make sure the tests pass (cf. https://circleci.com/gh/all-contributors/all-contributors-cli/865?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link), I briefly looked at the error which states that a module is missing.
Make sure the test passes locally.

@Berkmann18
Copy link
Member

Let us know if you need help.

@Berkmann18 Berkmann18 mentioned this pull request Jan 3, 2020
Closed
4 tasks
Berkmann18
Berkmann18 approved these changes Jan 3, 2020
View reviewed changes
Copy link
Member

@Berkmann18 Berkmann18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@Berkmann18 Berkmann18 merged commit 0993a90 into all-contributors:master Jan 3, 2020
@smoia
Copy link
Contributor Author

smoia commented Jan 3, 2020

Ok, sorry it took me so long!
The problem was that node and yarn were outdated - hence the failing of the tests.
I updated required yarn and node.

@Berkmann18
Copy link
Member

@all-contributors please add @smoia for code

@allcontributors allcontributors bot mentioned this pull request Jan 3, 2020
Merged
@allcontributors
Copy link
Contributor

@Berkmann18

I've put up a pull request to add @smoia! 🎉

@Berkmann18
Copy link
Member

@smoia It's fine!

@all-contributors-release-bot
Copy link
Member

🎉 This PR is included in version 6.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@smoia smoia deleted the data_contributor branch January 3, 2020 22:44
@smoia smoia mentioned this pull request Jan 3, 2020
Merged
Berkmann18 pushed a commit that referenced this pull request May 24, 2020
@allcontributors @gr2m
docs: add fennecdjay as a contributor (#231)
d87bd0a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Berkmann18 Berkmann18 Berkmann18 approved these changes

Assignees
No one assigned
Labels
enhancement maintenance released status: accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smoia @Berkmann18 @all-contributors-release-bot