-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow defining class(es) for list items #5
Comments
Hi there 👋 The feature you're asking for should be doable. For what it's worth, using this project on the Bootstrap website has been tried in the past and it was decided not to continue with this solution: see #3. Not sure if requirements on that matter have changed or not. |
Time has passed, progress was made. Together with @XhmikosR we nuked some custom plugins lately. Only two open task ahead |
I'm not sure we can do this @m5o. I have already tried it and it ended up being a lot messier. It's OK to keep one or two plugins. The problem is with the custom plugins in the repo; those slow down things the most. |
@XhmikosR It would be really valuable, because it will be allow usage of github-pages support out-of-the-box. This is a huge thing. |
There is a balance between every thing. And here, personally, it just is more complex than it has to be. We don't really care to make the docs build on GitHub pages. It's an extra step we have learned to live with. But, if we can get rid of the custom plugins (not gems) then at least the build should speed up. Either way this is outside of this repo's scope :) |
It could get 57.000+ forks the possibility to rollout a docs page. This will benefit the bootstrap environment a lot. |
I don't see any benefit there. Also, our gh-pages branch includes older docs versions. We just can't use GitHub pages. |
I could see this feature request being useful to others, so here's how to use it. |
Hey @allejo 👋
The popular twbs/bootstrap repo is currently using a custom plugin for generating the toc.
With your help, we could replace the old custom toc with your
jekyll-toc
which has out-of-the-box support for github-pages.I wanted to ask, if you want to help make jekyll-toc ready to be replaced in bootstrap.
I've made a branch in my fork an played a bit:
https://github.com/m5o/bootstrap/tree/jekyll-toc
TOC Usage
Expected TOC
Actual TOC
ToDos
li
have custom classes including the leveltoc-entry hX
The text was updated successfully, but these errors were encountered: