Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move heavy dependencies to peerDependencies #9

Open
aleclarson opened this issue Oct 15, 2021 · 0 comments
Open

Move heavy dependencies to peerDependencies #9

aleclarson opened this issue Oct 15, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@aleclarson
Copy link
Contributor

aleclarson commented Oct 15, 2021 •
edited
Loading

Heavy dependencies include:

  • html-minifier-terser (in next branch only)
  • imagemin-pngquant
  • imagemin-webp (in next branch only)
  • svgo

All of these take ~5 MB each.

Benefits:

  • Less wasted space when not using a specific feature
  • Faster installation

Drawbacks:

  • More burdensome setup/maintenance
  • A few wasted MB isn't the end of the world
  • Their dependencies may overlap, so the "5 MB" figure could be overstated
@aleclarson aleclarson added the enhancement New feature or request label Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aleclarson