From 230f0567ad7eff5aa195799530c4c4b49babe409 Mon Sep 17 00:00:00 2001 From: ChrisBAshton Date: Thu, 30 Jan 2025 10:17:42 +0000 Subject: [PATCH] Remove unused `format_name` property See https://github.com/alphagov/specialist-publisher/pull/2998 Trello: https://trello.com/c/ZiFU2o6B --- docs/finder-content-item.md | 7 ------- features/fixtures/aaib_reports_example.json | 1 - features/fixtures/all_content.json | 1 - features/fixtures/cma_cases_content_item.json | 1 - features/fixtures/news_and_communications.json | 1 - .../fixtures/news_and_communications_with_checkboxes.json | 1 - features/fixtures/official_documents.json | 1 - features/fixtures/policy_and_engagement.json | 1 - features/fixtures/statistics.json | 1 - spec/support/content_helper.rb | 1 - 10 files changed, 16 deletions(-) diff --git a/docs/finder-content-item.md b/docs/finder-content-item.md index a52e51be6..2edeb9092 100644 --- a/docs/finder-content-item.md +++ b/docs/finder-content-item.md @@ -54,13 +54,6 @@ For example, rejecting all documents which don't have a policy would need a hash } ``` -## `format_name` - -A string. Optional. - -Not specifically used by the Finder. Usually a singularised version of the title of the Finder - `"Competition and Markets Authority case"` for [`/cma-cases`](https://www.gov.uk/cma-cases) for example. -However there are edge cases where it's not the same such as `"Medical safety alert"` for [Alerts and recalls for drugs and medical devices](https://www.gov.uk/drug-device-alerts). - ## `default_order` A string. Optional. diff --git a/features/fixtures/aaib_reports_example.json b/features/fixtures/aaib_reports_example.json index a7143891d..8a6421670 100644 --- a/features/fixtures/aaib_reports_example.json +++ b/features/fixtures/aaib_reports_example.json @@ -95,7 +95,6 @@ "filter":{ "document_type":"aaib_report" }, - "format_name":"Air Accidents Investigation Branch report", "show_summaries":true, "facets":[ { diff --git a/features/fixtures/all_content.json b/features/fixtures/all_content.json index 19f068d49..07c8bf000 100644 --- a/features/fixtures/all_content.json +++ b/features/fixtures/all_content.json @@ -108,7 +108,6 @@ "type": "hidden_clearable" } ], - "format_name": "Documents", "reject": { "link": [ "/search/all" diff --git a/features/fixtures/cma_cases_content_item.json b/features/fixtures/cma_cases_content_item.json index b21e680c1..d7c173f2c 100644 --- a/features/fixtures/cma_cases_content_item.json +++ b/features/fixtures/cma_cases_content_item.json @@ -733,7 +733,6 @@ "filter": { "document_type": "cma_case" }, - "format_name": "Competition and Markets Authority case", "show_summaries": false, "facets": [ { diff --git a/features/fixtures/news_and_communications.json b/features/fixtures/news_and_communications.json index 84590292f..7cde5460f 100644 --- a/features/fixtures/news_and_communications.json +++ b/features/fixtures/news_and_communications.json @@ -47,7 +47,6 @@ "filter":{ "content_purpose_subgroup": ["news", "speeches_and_statements"] }, - "format_name":"News or communiqué", "show_summaries":true, "sort": [ { diff --git a/features/fixtures/news_and_communications_with_checkboxes.json b/features/fixtures/news_and_communications_with_checkboxes.json index f7bcff87f..9c89f4a0e 100644 --- a/features/fixtures/news_and_communications_with_checkboxes.json +++ b/features/fixtures/news_and_communications_with_checkboxes.json @@ -46,7 +46,6 @@ "filter":{ "content_purpose_supergroup":"news_and_communications" }, - "format_name":"News or communiqué", "show_summaries":true, "sort": [ { diff --git a/features/fixtures/official_documents.json b/features/fixtures/official_documents.json index 8ffe339ff..ba264de7a 100644 --- a/features/fixtures/official_documents.json +++ b/features/fixtures/official_documents.json @@ -26,7 +26,6 @@ "filter": { "has_official_document": true }, - "format_name": "Official documents", "show_summaries": true, "sort": [ { diff --git a/features/fixtures/policy_and_engagement.json b/features/fixtures/policy_and_engagement.json index db895a576..23f583f15 100644 --- a/features/fixtures/policy_and_engagement.json +++ b/features/fixtures/policy_and_engagement.json @@ -58,7 +58,6 @@ "policy_and_engagement" ] }, - "format_name": "document", "show_summaries": true, "sort": [ { diff --git a/features/fixtures/statistics.json b/features/fixtures/statistics.json index f03c0418a..4b5c3a14c 100644 --- a/features/fixtures/statistics.json +++ b/features/fixtures/statistics.json @@ -43,7 +43,6 @@ "beta_message": "This is in beta. Please take our survey.", "document_noun":"result", "filter":{}, - "format_name":"statistic", "show_summaries":true, "sort": [ { diff --git a/spec/support/content_helper.rb b/spec/support/content_helper.rb index 06755a6e0..bbcbee368 100644 --- a/spec/support/content_helper.rb +++ b/spec/support/content_helper.rb @@ -486,7 +486,6 @@ def example_cma_cases_finder "filter" => { "document_type" => "cma_case", }, - "format_name" => "Competition and Markets Authority case", "show_summaries" => false, } finder["links"] = {