Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explanatory text and improve headings in Sass API Reference #114

Open
2 tasks
EoinShaughnessy opened this issue Apr 20, 2021 · 4 comments
Open
2 tasks
Assignees
Labels
2i Needs to be 2i'd by team member, external tech writer or content designer accessibility documentation Improvements or additions to documentation Effort: days Used by the team when triaging small story

Comments

@EoinShaughnessy
Copy link
Contributor

EoinShaughnessy commented Apr 20, 2021

What

Add explanatory/introductory text under headings in Sass API Reference. Possibly also revise some headings to make them more meaningful to users.

Why

Because of how the Sass API Reference is generated, no explanatory text displays under its headings. This means we are not telling users what the different sections can help them do.

There may also be an impact on accessibility - using headings that do not appropriately describe their related content is a failure of WCAG 2.4.6: Headings and Labels.

For example, would anyone coming to this content for the first time necessarily know what we mean by 'Assets'/ 'Settings' here? 👇🏻 Or even what the 'Sass API reference section' is for, generally?

image

Who needs to know about this

Laurence, Eoin

Done when

*However, the bulk of this work will be in the govuk-frontend-docs repo.

@EoinShaughnessy EoinShaughnessy added awaiting triage Needs triaging by team documentation Improvements or additions to documentation Effort: days Used by the team when triaging and removed awaiting triage Needs triaging by team labels Apr 20, 2021
@EoinShaughnessy EoinShaughnessy added the 2i Needs to be 2i'd by team member, external tech writer or content designer label Oct 13, 2021
@EoinShaughnessy EoinShaughnessy changed the title Add descriptions to groups in Sass API Reference Add explanatory text under headings in Sass API Reference Oct 13, 2021
@EoinShaughnessy EoinShaughnessy changed the title Add explanatory text under headings in Sass API Reference Add explanatory text and improve headings in Sass API Reference Oct 19, 2021
@EoinShaughnessy
Copy link
Contributor Author

@kellylee-gds I asked the Accessibility Team whether there needs to be content under headings. They said:

It’s not an accessibility fail, but it is a preference for some screen reader users.

Basically, if there’s no content between headings, some users are concerned there is something there that they can’t access

so spend a while trying to get their software to access the ‘thing’ between headings

but when there is no ‘thing’ and it just leads onto another heading, this could cause confusion and waste time

@stevenjmesser
Copy link

@colinrotherham Do you know if we'll can continue using SassDoc now that we've switched to Dart Sass? Trying to work out whether this might be resolved by using a different API reference generator or whether we still need to solve the issue.

@colinrotherham
Copy link
Contributor

colinrotherham commented May 26, 2023

@stevenjmesser Yeah no blockers continuing to use it

They're after help maintaining the project though:

Locally we use a different SassDoc theme (see screenshot) but it's hidden when deployed to Heroku

These docs render the same SassDoc data

Even if there's no way of adding explanatory/introductory content to the SassDoc data itself, I'm sure we could match up known sections (in the SassDoc data) with content maintained in this repository before it gets rendered

SassDoc default theme

@colinrotherham
Copy link
Contributor

Sounds like #116 is an improvement right away

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2i Needs to be 2i'd by team member, external tech writer or content designer accessibility documentation Improvements or additions to documentation Effort: days Used by the team when triaging small story
Projects
None yet
Development

No branches or pull requests

5 participants