Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header component CSS is accounting for users not building the header component correctly #2746

Closed
Tracked by #3524
owenatgov opened this issue Aug 3, 2022 · 0 comments · Fixed by #3596
Closed
Tracked by #3524
Assignees
Labels
🕔 hours A well understood issue which we expect to take less than a day to resolve. tech debt
Milestone

Comments

@owenatgov
Copy link
Contributor

Cause

With #2727 we added some additional CSS to account for is teams hadn't added the extra hidden attribute to the menu button if they're not using our macros to stop the change resulting in a regression. In the next breaking release, we should amend this CSS to presume that teams have updated their macros and clean up the offending CSS.

Consequences

We are shipping CSS that is only necessary for a specific case that we expect to not be a problem with the next breaking release.

We are shipping CSS that is inconsistent within the same file with how we handle hiding elements as a fallback for when hidden isn't supported.

Impact of debt

Low

Reason (impact of debt)

No response

Effort to pay down

Low

Reason (effort to pay down)

No response

Overall rating

Low

Reason (overall rating)

No response

@owenatgov owenatgov added 🕔 hours A well understood issue which we expect to take less than a day to resolve. tech debt labels Aug 3, 2022
@owenatgov owenatgov added this to the v5.0 milestone Aug 3, 2022
@querkmachine querkmachine self-assigned this May 9, 2023
@querkmachine querkmachine moved this from Backlog 🗄 to In progress 📝 in GOV.UK Design System cycle board May 9, 2023
@querkmachine querkmachine moved this from In progress 📝 to Needs review 🔍 in GOV.UK Design System cycle board May 9, 2023
@querkmachine querkmachine moved this from Needs review 🔍 to Ready to release 🚀 in GOV.UK Design System cycle board May 9, 2023
@36degrees 36degrees moved this from Ready to release 🚀 to Done 🏁 in GOV.UK Design System cycle board Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕔 hours A well understood issue which we expect to take less than a day to resolve. tech debt
Projects
Development

Successfully merging a pull request may close this issue.

2 participants