Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider making the I18n class private #2927

Closed
2 tasks done
colinrotherham opened this issue Oct 18, 2022 · 1 comment · Fixed by #2941
Closed
2 tasks done

Consider making the I18n class private #2927

colinrotherham opened this issue Oct 18, 2022 · 1 comment · Fixed by #2941
Assignees
@romaricpascal
Labels
🔍 investigation javascript localisation
Milestone
v4.4.0

Comments

@colinrotherham
Copy link
Contributor

colinrotherham commented Oct 18, 2022 •
edited by romaricpascal
Loading

What

Do we want to consider I18n "private" whilst we continue changing, refactoring, improving?

We've already noted in #2926 that we may rename our I18n class

Why

Making features "public" means we can't make breaking changes without major releases
Making features "private" (or for internal use) means we're relatively free to make changes where needed

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

  • Decision made on private versus public
  • Change made in code to remove GOVUKFrontend.I18n from govuk/all.js
@colinrotherham colinrotherham added this to the v4.4.0 milestone Oct 18, 2022
@romaricpascal romaricpascal mentioned this issue Oct 24, 2022
Merged
@romaricpascal
Copy link
Member

Concensus at the meeting was to keep it private for now and possibly open it up in a future release, so opened up #2941 to deal with it 😊

@romaricpascal romaricpascal self-assigned this Oct 24, 2022
@36degrees 36degrees mentioned this issue Oct 24, 2022
Closed
2 tasks
@36degrees 36degrees mentioned this issue Nov 8, 2022
Open
5 tasks
@claireashworth claireashworth mentioned this issue Feb 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romaricpascal romaricpascal

Labels
🔍 investigation javascript localisation
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
v4.4.0
Development

Successfully merging a pull request may close this issue.

Make the I18n class private alphagov/govuk-frontend
2 participants
@romaricpascal @colinrotherham