Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: add support for passing id to button macro #2999

Closed
edwardhorsford opened this issue Nov 10, 2022 · 0 comments · Fixed by #3344
Closed

Suggestion: add support for passing id to button macro #2999

edwardhorsford opened this issue Nov 10, 2022 · 0 comments · Fixed by #3344
Labels
button feature request User requests a new feature nunjucks
Milestone

Comments

@edwardhorsford
Copy link
Contributor

I'd like to propose that the button macro accepts id as an optional argument. It feels like it might be good to add for consistency of api with other components - and considered for all compopnents.

I expected that all the macros would have a few standard arguments - like id, classes, etc.

Related slack discussion

Related component

Button

Context

Assumed that id was a standard part of the API and would exist on all components

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
button feature request User requests a new feature nunjucks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants