-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minified JS in dist
errors in IE8
#3136
Labels
🐛 bug
Something isn't working the way it should (including incorrect wording in documentation)
Milestone
Comments
36degrees
added
the
🐛 bug
Something isn't working the way it should (including incorrect wording in documentation)
label
Dec 23, 2022
Looks like this might be fixed by #3013. |
We now have two fixes to pick:
But equally we could merge 1) and take on 2) at a later date |
I've checked out previous releases, enabled UglifyJS, and tested in IE8 via Browserstack GOV.UK Frontend releases
See full diff in compare view |
Closed by #3137 |
This was
linked to
pull requests
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🐛 bug
Something isn't working the way it should (including incorrect wording in documentation)
Description of the issue
The minified JavaScript we provide in the
dist
directory (which is also included in the zip file attached to each release) errors in IE8 – seemingly because of transformations made by Uglify JS.Although we have plans to drop support for IE8-10 shortly, our current browser support includes Internet Explorer 8, 9 and 10, 'although components may not look perfect'.
Steps to reproduce the issue
Load the review app in IE8 (after #3050 has been merged)
Actual vs expected behaviour
The page should load without errors. Instead we get:
Environment (where applicable)
The text was updated successfully, but these errors were encountered: