Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minified JS in dist errors in IE8 #3136

Closed
36degrees opened this issue Dec 23, 2022 · 4 comments · Fixed by #3137 or #3013
Closed

Minified JS in dist errors in IE8 #3136

36degrees opened this issue Dec 23, 2022 · 4 comments · Fixed by #3137 or #3013
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation)
Milestone

Comments

@36degrees
Copy link
Contributor

Description of the issue

The minified JavaScript we provide in the dist directory (which is also included in the zip file attached to each release) errors in IE8 – seemingly because of transformations made by Uglify JS.

Although we have plans to drop support for IE8-10 shortly, our current browser support includes Internet Explorer 8, 9 and 10, 'although components may not look perfect'.

Steps to reproduce the issue

Load the review app in IE8 (after #3050 has been merged)

Actual vs expected behaviour

The page should load without errors. Instead we get:

Object does not support this property or method

Environment (where applicable)

  • Operating system: Windows 7
  • Browser: Internet Explorer
  • Browser version: 8.0
  • GOV.UK Frontend Version: N/A
@36degrees 36degrees added the 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) label Dec 23, 2022
@36degrees
Copy link
Contributor Author

Looks like this might be fixed by #3013.

@colinrotherham
Copy link
Contributor

We now have two fixes to pick:

  1. Enable UglifyJS compatibility workarounds #3137
  2. Swap JavaScript minifier from UglifyJS to terser #3013

But equally we could merge 1) and take on 2) at a later date

@36degrees 36degrees modified the milestones: v5.0, [NEXT] Jan 13, 2023
@colinrotherham
Copy link
Contributor

I've checked out previous releases, enabled UglifyJS, and tested in IE8 via Browserstack

GOV.UK Frontend releases

See full diff in compare view

@colinrotherham
Copy link
Contributor

Closed by #3137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation)
Projects
2 participants