Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't override servicename on individual pages #129

Closed
edwardhorsford opened this issue Jan 19, 2016 · 2 comments · Fixed by #335
Closed

Can't override servicename on individual pages #129

edwardhorsford opened this issue Jan 19, 2016 · 2 comments · Fixed by #335
Assignees
Labels
🐛 Bug Something isn't working the way it should (including incorrect wording in documentation)

Comments

@edwardhorsford
Copy link
Contributor

With the move to nunjucks, we can no longer override the service name on individual pages. Something to do with going up and sideways with the templates.

To do:

  • Refactor propositional-navigation - do we even need it? Should service name sit elsewhere?
  • Make it possible to set the service name on a page-by-page basis.
@timpaul timpaul added the 🐛 Bug Something isn't working the way it should (including incorrect wording in documentation) label Mar 30, 2016
@sanjaypoyzer
Copy link
Contributor

Thought I'd flag up how I've just solved this issue:

In config.js:

  serviceName: {
    main : "Pay online for offline services",
    roomRent : "Pay for hiring a government venue"
  },

In my main index.js:

<h1 class="heading-xlarge">{{ serviceName.main }}</h1>
<ul>
  <li class="list list-bullet">
    <a href="/room-rent">{{ serviceName.roomRent}}</a>
  </li>
</ul>

In all the room-rent pages:

<h1 class="heading-xlarge">{{ serviceName.roomRent }}</h1>

So we don't really need to refactor anything as I see it, just need to add guidance that the above is possible.

@sanjaypoyzer
Copy link
Contributor

Ah misunderstood the bug - The above doesn't solve the propositional navigation problem, only the ability to use individual service names in headers in the page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working the way it should (including incorrect wording in documentation)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants