Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect HTTP to HTTPS #582

Closed
Nooshu opened this issue Dec 8, 2017 · 5 comments
Closed

Redirect HTTP to HTTPS #582

Nooshu opened this issue Dec 8, 2017 · 5 comments

Comments

@Nooshu
Copy link

Nooshu commented Dec 8, 2017

We can currently use two urls to get to elements. I believe Search engines are intelligent enough to know the difference so there shouldn't be an SEO impact, but if it is a simple fix then it would be worth making it.

How would you expect it to work?

I would expect HTTP to redirect to HTTPS.

Feel free to suggest a fix...

There is an express module available that we may be able to use that can help us do this. More details about it here

@joelanman
Copy link
Contributor

This was done and then reverted a while ago, not sure why #501

@Nooshu
Copy link
Author

Nooshu commented Dec 8, 2017

Original changes in #480. Looks to be using a similar method as used in the heroku-ssl-redirect. @igloosi do you happen to know what broke when this was deployed?

@joelanman
Copy link
Contributor

joelanman commented Dec 8, 2017

Might be reading it wrong since I'm on mobile but looks like a possible bug in the original pr:

var utils = path.join(__dirname, '/lib/utils.js')

I think this needs a 'require', like the similar lines above it

@Nooshu
Copy link
Author

Nooshu commented Dec 8, 2017

Well spotted @joelanman, certainly worth investigating. Or we could try the module listed if that is easier?

@36degrees
Copy link
Contributor

Following the launch of the GOV.UK Design System, GOV.UK Elements will now only get major bug fixes and security patches, so I'm going to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants