Add template pages for content and questions #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
for prototyping, I'd use |
|
@joelanman could we look at the javascript back as a separate PR? Other pages in the kit do it manually, and would be better to tackle in one go. |
|
Updated index: |
|
I think the examples are in rough order of where they appear in a transaction, so maybe Content page and Question pages should come just after Task list? |
joelanman
reviewed
Apr 4, 2017
| Heading goes here | ||
| </h1> | ||
|
|
||
| <p>This is the a paragraph of text. It explains in more detail what has happened and wraps across several lines.</p> |
joelanman
reviewed
Apr 4, 2017
|
|
||
| <p>[Insert question content here]</p> | ||
|
|
||
| <p>[See <a href="http://govuk-elements.herokuapp.com/form-elements/">GOV.UK Elements</a> for examples]</p> |
edwardhorsford
force-pushed
the
add_content_question_pages
branch
from
41fafef to
ff7aef4
Compare
edwardhorsford
force-pushed
the
add_content_question_pages
branch
from
ff7aef4 to
6435b0a
Compare
|
Looks good, thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two new template pages to the kit.
For links (back links, action urls, etc), I've gone with
href="/url/of/previous/page". Does this seem correct?Using POSTs
These templates work with #340 and start moving us towards using POSTs. That PR should probably get merged first.
Template content page
A basic content page - useful for things like:
Looks like:
Template question page blank
A basic question page, containing:
Will be useful for people grabbing snippets from Elements.
Looks like:
