Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML validation bug in cookie banner #3559

Open
maxgds opened this issue Aug 18, 2023 · 2 comments
Open

HTML validation bug in cookie banner #3559

maxgds opened this issue Aug 18, 2023 · 2 comments
Assignees
@davidtrussler
Labels
bug code quality good first issue

Comments

@maxgds
Copy link
Contributor

maxgds commented Aug 18, 2023 •
edited
Loading

What:

Noted by Anika, https://gds.slack.com/archives/CARGH33JS/p1692285458097259 we have <p> tags inside a <span> tag in the cookie banner - the fix is probably to simply switch the span to a div.

Why:

No visible issues, but invalid HTML is not a good look. Affects all pages as the banner is presented to whatever page is the first landing page.

Prioritisation score: 3

Reach: 3, Severity: 1, Effort: 1
@KludgeKML
Copy link
Contributor

Is the span even doing anything useful? Like, could those P tags just be straight inside the enclosing div?

@maxgds
Copy link
Contributor Author

maxgds commented Aug 18, 2023

Is the span even doing anything useful? Like, could those P tags just be straight inside the enclosing div?

It's the parent container that gets hidden upon choosing a preference, so it does serve a purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidtrussler davidtrussler

Labels
bug code quality good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@KludgeKML @davidtrussler @maxgds