Skip to content
This repository has been archived by the owner on Dec 6, 2024. It is now read-only.

Directory.ExistsDriveOrFolderOrFile fails on global root path, so a simple file copy from a shadow copy fails with "device GLOBALROOT not ready" #433

Closed
CyberSinh opened this issue Apr 1, 2018 · 8 comments
Assignees
Labels
Milestone

Comments

@CyberSinh
Copy link
Contributor

Seems to be a very severe bug!
Hope my simple #432 pull request could help.
Thank you for this wonderful library.

@Yomodo Yomodo self-assigned this Apr 2, 2018
@Yomodo Yomodo added the Bug 🪲 label Apr 2, 2018
@Yomodo Yomodo added this to the vNext milestone Apr 2, 2018
@Yomodo
Copy link
Collaborator

Yomodo commented Apr 2, 2018

Thanks!

@Yomodo
Copy link
Collaborator

Yomodo commented Apr 2, 2018

Fixed with #432

@Yomodo Yomodo closed this as completed Apr 2, 2018
@CyberSinh
Copy link
Contributor Author

Since this is a severe bug, would it be possible to release a new version 2.2.1 of AlphaFS (nuget package) soon?

@Yomodo
Copy link
Collaborator

Yomodo commented Apr 4, 2018

I guess the severity is (only) related to shadow file copying, and not with regular file copies.
@alphaleonis Any thoughts on this?

@alphaleonis
Copy link
Owner

Yeah, the global root paths are not commonly used outside of Shadow copies to my knowledge, but then again, the reason for starting with AlphaFS in the first place was actually to support copying files from shadow copies, so it's a good point. If the bug is fixed I'll do a new release shortly.

@Yomodo Was the fix only done on develop or also on master?

@Yomodo
Copy link
Collaborator

Yomodo commented Apr 5, 2018

@alphaleonis Only in develop.

@alphaleonis
Copy link
Owner

@Yomodo Okay. Bugfixes should preferrably be made in master, so that new features can be worked on in develop while still releasing minor bugfix releases. But since that's the only fix made so far I'll just merge it down to master and create a new release from there. :)

@alphaleonis
Copy link
Owner

Fixed in 2.2.1 which has been released now. :)

@Yomodo Yomodo removed this from the vNext milestone Apr 25, 2018
@Yomodo Yomodo added this to the Release 2.2 milestone Jul 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants