-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"getPaddings is not defined" in scrolloverflow.js after resize #3095
Comments
The issue was fixed here thanks to @Odrin that detected it. Make sure to use the unminified version of the dev branch. (you can minifiy it yourself if you wish, just not updated in the dev branch) |
I'm take the fixed file and update it successfully, but this error still exist i don't know what can i do for that, |
@AbdulkaderTahhan you'll have to provide an isolated reproduction of it in jsfiddle or codepen to prove it. |
Here the example for this issue http://websitk.com/public/main/, |
@AbdulkaderTahhan your reproduction is not isolated. So it is not valid for me to check. |
Greetings! Yeah, unfortunately, I'm getting the same issue when using the un-minified/minified cdn version. This example is pretty isolated: https://codepen.io/petebarr/pen/9dfa27828a12af469bf67da410346d09 Cheers! |
@petebarr see my comment above yours. You should be using the dev version as the change was not yet merged into any public release. You are not using the dev version. Use the link i posted. |
May sound like a dumb question but is that the dev version of fullscreen.js or scrolloverflow.js? |
Use the latest of both. You'll get less bugs this way ;) |
Thanks, that works in Codepen now using the following URLs in "Add External Scripts/Pens": https://rawgit.com/alvarotrigo/fullPage.js/dev/vendors/scrolloverflow.js Appreciate it! |
Hey, are there any plans, when this fix will be available over npm? |
@mexn soon! In the next release. Hopefully by the end of this week! |
That's great news, thanks! |
@mexn I've just published the new release 2.9.7! |
@alvarotrigo This isn't fixed in 2.9.7 for me. However if I use the code from the dev branch IE
|
@hortonelectric please provide an isolated reproduction. Working as expected on the demo page. |
@hortonelectric ok, I've noticed I forgot to update the minified version. The unminified one should work as expected. Merging the minified one now, but you won't get it on npm. So please get it from here until the next release gets pushed to npm. #3192 |
I'm using fullPage (2.9.6) with scrollOverflow (5.2.0) and am getting the error
getPaddings is not defined
after resizing the window.I was able to fix it by moving the
getPaddings
function out of and above thescrollBarHandler
function.The text was updated successfully, but these errors were encountered: