Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"getPaddings is not defined" in scrolloverflow.js after resize #3095

Closed
arthurdewolf opened this issue Feb 8, 2018 · 17 comments
Closed

"getPaddings is not defined" in scrolloverflow.js after resize #3095

arthurdewolf opened this issue Feb 8, 2018 · 17 comments

Comments

@arthurdewolf
Copy link

arthurdewolf commented Feb 8, 2018

I'm using fullPage (2.9.6) with scrollOverflow (5.2.0) and am getting the error getPaddings is not defined after resizing the window.

I was able to fix it by moving the getPaddings function out of and above the scrollBarHandler function.

@alvarotrigo
Copy link
Owner

I'm using fullPage (2.9.6) with scrollOverflow (5.2.0) and am getting the error getPaddings is not defined after resizing the window.

The issue was fixed here thanks to @Odrin that detected it.

Make sure to use the unminified version of the dev branch. (you can minifiy it yourself if you wish, just not updated in the dev branch)

@AbdulkaderTahhan
Copy link

I'm take the fixed file and update it successfully, but this error still exist i don't know what can i do for that,
thanks a lot

@alvarotrigo
Copy link
Owner

@AbdulkaderTahhan you'll have to provide an isolated reproduction of it in jsfiddle or codepen to prove it.

@AbdulkaderTahhan
Copy link

AbdulkaderTahhan commented Feb 20, 2018

Here the example for this issue http://websitk.com/public/main/,
i use this file https://goo.gl/mtGNBk but when click F12 on the browser you will find the issue

@alvarotrigo
Copy link
Owner

@AbdulkaderTahhan your reproduction is not isolated. So it is not valid for me to check.
And, as I said, you should be using the file from the dev folder.

@petebarr
Copy link

Greetings!

Yeah, unfortunately, I'm getting the same issue when using the un-minified/minified cdn version. This example is pretty isolated: https://codepen.io/petebarr/pen/9dfa27828a12af469bf67da410346d09

Cheers!

@alvarotrigo
Copy link
Owner

@petebarr see my comment above yours. You should be using the dev version as the change was not yet merged into any public release. You are not using the dev version. Use the link i posted.

@petebarr
Copy link

May sound like a dumb question but is that the dev version of fullscreen.js or scrolloverflow.js?
Thanks again!

@alvarotrigo
Copy link
Owner

Use the latest of both. You'll get less bugs this way ;)

@petebarr
Copy link

Thanks, that works in Codepen now using the following URLs in "Add External Scripts/Pens":

https://rawgit.com/alvarotrigo/fullPage.js/dev/vendors/scrolloverflow.js
https://rawgit.com/alvarotrigo/fullPage.js/dev/dist/jquery.fullpage.js

Appreciate it!

@mexn
Copy link

mexn commented Apr 3, 2018

Hey,

are there any plans, when this fix will be available over npm?

@alvarotrigo
Copy link
Owner

@mexn soon! In the next release. Hopefully by the end of this week!

@mexn
Copy link

mexn commented Apr 3, 2018

That's great news, thanks!

@alvarotrigo
Copy link
Owner

@mexn I've just published the new release 2.9.7!

@hortonelectric
Copy link

hortonelectric commented Apr 11, 2018

@alvarotrigo This isn't fixed in 2.9.7 for me. However if I use the code from the dev branch IE https://rawgit.com/alvarotrigo/fullPage.js/dev/dist/jquery.fullpage.js then it works fine.

Uncaught ReferenceError: getPaddings is not defined
    at Object.update (scrolloverflow.js:2736)
    at n (scrolloverflow.js:2490)
    at HTMLDivElement.<anonymous> (scrolloverflow.js:2524)
    at Function.each (jquery.min.js:2)
    at w.fn.init.each (jquery.min.js:2)
    at r (scrolloverflow.js:2516)
    at s [as createScrollBarForAll] (scrolloverflow.js:2438)
    at Ke (jquery.fullpage.js:466)
    at jquery.fullpage.js:2151
update @ scrolloverflow.js:2736
n @ scrolloverflow.js:2490
(anonymous) @ scrolloverflow.js:2524
each @ jquery.min.js:2
each @ jquery.min.js:2
r @ scrolloverflow.js:2516
s @ scrolloverflow.js:2438
Ke @ jquery.fullpage.js:466
(anonymous) @ jquery.fullpage.js:2151
setTimeout (async)
Mo @ jquery.fullpage.js:2150
dispatch @ jquery.min.js:2
y.handle @ jquery.min.js:2

@alvarotrigo
Copy link
Owner

@hortonelectric please provide an isolated reproduction. Working as expected on the demo page.

@alvarotrigo
Copy link
Owner

alvarotrigo commented Apr 11, 2018

@hortonelectric ok, I've noticed I forgot to update the minified version. The unminified one should work as expected. Merging the minified one now, but you won't get it on npm. So please get it from here until the next release gets pushed to npm. #3192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants