feat: React-agnostic core #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47
Fixes #134
This extracts the core library to be agnostic of React to allow usage e.g. in API routes., please refer to the new section in the docs to learn more. I've updated the advanced example in this branch to demonstrate the usage in API routes including locale negotiation that I'd recommend.
The core offers the same capabilities that were previously exposed via
useTranslationsanduseIntl, with the minor difference that rich text formatting operates with strings only, to avoid usage of React in the core (many thanks to @dbrxnds for the feedback and discussion here!). Strict typing for messages is enabled for the new APIs as well.Feedback about the API, the docs and generally if everything works as expected would be greatly appreciated!
Preview