Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: purpose of reset_mems variable #3

Open
zzingae opened this issue Feb 20, 2022 · 0 comments
Open

Question: purpose of reset_mems variable #3

zzingae opened this issue Feb 20, 2022 · 0 comments

Comments

@zzingae
Copy link

zzingae commented Feb 20, 2022

Hello.

In the training phase, there's reset_mems for resetting memory.
When the new music (sequence) begins, it blocks attention to memory of previous music by setting reset_mems=True.
https://github.com/amazon-research/transformer-gan/blob/1ccc9f251c1b1d054c1acc8be36c1da7bf8cf11c/model/mem_transformer.py#L529

However, since memory length (1024) is longer than batch length (128), new music sequence can do attention to previous music after one block.
So, it seems that new sequence can do attention to 'prev sequence memory (896) + cur sequece memory (128)'.
I am wondering if this is intentional.

Thank you for sharing code!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant