Break up Amber::Router::Cookies module

[dwightwatson]

Description

The file for Amber::Router::Cookies contains multiple class and module definitions, and Amber::Router::Cookies may not even need to be a class itself. I think it would be beneficial for the classes and modules defined in the namespace to be broken up into individual files so that it's easier to find.

I suspect that there may be other instances of file/class inconsistencies that would be good to address as well.

• Amber::Router::Session::Store located in amber/router/session/session_store.cr
• Amber::Pipe located in amber/pipes directory

[drujensen]

@eliasjpr wdyt?

[eliasjpr]

I thought of doing that previously. I think is a good idea

[dwightwatson]

Was looking at renaming Amber::Pipe to Amber::Pipes versus renaming the directory to amber/pipe.

There might be room for discussion around naming and seeing if we can develop some consistency between the module names.

One option might be to aim for singular names. It may be better to go from Amber::Validators to Amber::Validation.

Amber::CLI
Amber::Controller
Amber::DSL
Amber::Environment
Amber::Exception
Amber::Extension
Amber::Pipe
Amber::Router
Amber::Server
Amber::Support
Amber::Validation
Amber::WebSocket

[robacarp]

Some will always be singular, server for example. But I think any namespaces/folders which represent a collection of things should be plural. Validations, Extensions, Support, etc.

Is Support plural? Whatever...

[eliasjpr]

I was in the past proposing the idea to modularized the code further, to something maybe towards this I know the team was hesitant to do so then. I am not sure how the team feels now, to slowly organize and document the project so we can generate crystal docs.

[drujensen]

@dwightwatson I agree with @robacarp. It depends on what the purpose of the module is. If it is name spacing a collection of items, it should be plural but if it's used to be included in a class, it's more than likely singular.

Closing this issue. Thanks for the contribution!