New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cookies: Look up Cookies is Set-Cookie header #135

Closed

1 task

eliasjpr opened this issue Jul 13, 2017 · 1 comment

Assignees

Labels

Contributor

eliasjpr commented Jul 13, 2017

The current Cookies implementation is not parsing the Set-Cookie header. See https://github.com/Amber-Crystal/amber/blob/master/src/amber/router/cookies.cr#L43

Basically we should be implementing/adding this https://github.com/crystal-lang/crystal/blob/3c3d3e2b830e81de0aa39b7af0cd6f82f759c410/src/http/cookie.cr#L150

Acceptance Criteria

Have the fill_from_headers load cookies from Set-Cookies

The text was updated successfully, but these errors were encountered:

eliasjpr added kind:bug status:help-wanted labels

eliasjpr self-assigned this

Contributor Author

eliasjpr commented Jul 18, 2017

Fixed with #138

eliasjpr closed this as completed

faustinoaq removed the status:help-wanted label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment