Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the database url config from the database.yml to the environment.yml #293

Closed
drujensen opened this issue Oct 7, 2017 · 3 comments
Closed

Comments

@drujensen
Copy link
Member

Description

Currently both Granite and Crecto are using the config/database.yml file to configure the database. They also both support DATABASE_URL environment variable override.

This request is to add an initializer for Granite and Crecto that will look for a database_url in the environment instead.

This will provide the ability to specify different databases for development, test and production. It should continue to honor the DATABASE_URL override environment variable.

@elorest
Copy link
Member

elorest commented Oct 8, 2017

I'd like to pair with you on this.

@eliasjpr
Copy link
Contributor

eliasjpr commented Nov 1, 2017

Can we start work on this? This seems to be fairly straightforward

@eliasjpr eliasjpr modified the milestones: Version TBD, 0.4.0 - Features & Bugfixes Nov 14, 2017
@elorest
Copy link
Member

elorest commented Nov 30, 2017

Complete!

@elorest elorest closed this as completed Nov 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants