Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort Migration Status #35

Closed
igbanam opened this issue Nov 13, 2018 · 1 comment · Fixed by #36
Closed

Sort Migration Status #35

igbanam opened this issue Nov 13, 2018 · 1 comment · Fixed by #36

Comments

@igbanam
Copy link

igbanam commented Nov 13, 2018

I recently ran my migrations and I realized that the order was not sorted in any order. I think there needs to be some sort of sorting when listing the migrations so developers know which changes happened to their codebase when.

I have taken a look at the codebase and seen that the proposed change is small. .sort_by { |k, v| v } should do the trick. But I am new to Crystal from Ruby and from what I read, this is syntactic sugar for hash.to_a.sort_by…. I'll raise my PR in a bit, but I would like a seasoned "Crystaline" — should totally be the name of Crystal programmers 🔥— to look through.

🙇

@igbanam
Copy link
Author

igbanam commented Nov 13, 2018

I did not know how to test this, since I am still very much a newb Crystaline. The shard isn't required by an application directly, and I didn't know how to build a new version of amber with this dependency to try it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant