You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I recently ran my migrations and I realized that the order was not sorted in any order. I think there needs to be some sort of sorting when listing the migrations so developers know which changes happened to their codebase when.
I have taken a look at the codebase and seen that the proposed change is small. .sort_by { |k, v| v } should do the trick. But I am new to Crystal from Ruby and from what I read, this is syntactic sugar for hash.to_a.sort_by…. I'll raise my PR in a bit, but I would like a seasoned "Crystaline" — should totally be the name of Crystal programmers 🔥— to look through.
🙇
The text was updated successfully, but these errors were encountered:
I did not know how to test this, since I am still very much a newb Crystaline. The shard isn't required by an application directly, and I didn't know how to build a new version of amber with this dependency to try it out.
I recently ran my migrations and I realized that the order was not sorted in any order. I think there needs to be some sort of sorting when listing the migrations so developers know which changes happened to their codebase when.
I have taken a look at the codebase and seen that the proposed change is small.
.sort_by { |k, v| v }
should do the trick. But I am new to Crystal from Ruby and from what I read, this is syntactic sugar forhash.to_a.sort_by…
. I'll raise my PR in a bit, but I would like a seasoned "Crystaline" — should totally be the name of Crystal programmers 🔥— to look through.🙇
The text was updated successfully, but these errors were encountered: