Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redo executes up even after failure #39

Closed
m-o-e opened this issue Feb 12, 2019 · 0 comments · Fixed by #47
Closed

redo executes up even after failure #39

m-o-e opened this issue Feb 12, 2019 · 0 comments · Fixed by #47
Labels
kind:bug

Comments

@m-o-e
Copy link
Contributor

m-o-e commented Feb 12, 2019

To reproduce:

  • Create a migration in which up succeeds but down fails

  • Run micrate up

  • Run micrate redo:

Migrating db, current version: 1, target: 0
An error ocurred executing migration 1. Error message is: ...
Migrating db, current version: 0, target: 1

I.e. micrate attempts to apply up even though the down failed.

Micrate should exit when an SQL error occurs and never perform any further steps.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Abort 'redo' when the 'down'-task fails
2 participants
@m-o-e @faustinoaq