Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part about "micrate create" in README is incorrect #70

Closed
LVMBDV opened this issue Oct 20, 2020 · 4 comments · Fixed by #71
Closed

Part about "micrate create" in README is incorrect #70

LVMBDV opened this issue Oct 20, 2020 · 4 comments · Fixed by #71

Comments

@LVMBDV
Copy link
Contributor

LVMBDV commented Oct 20, 2020

To create a new migration use the create subcommand. For example, micrate create add_users_table will create a new SQL migration file with a name such as...

micrate create only creates a database as specified in the database url. See here:

https://github.com/amberframework/micrate/blob/master/src/micrate/cli.cr#L134

@drujensen
Copy link
Member

Thanks for reporting this. Can you create a PR?

@LVMBDV
Copy link
Contributor Author

LVMBDV commented Oct 20, 2020

But do we want to just fix the README to omit migration creation or have create create migrations as expected and move the database creation to another command like createdb?

@drujensen
Copy link
Member

@LVMBDV
Copy link
Contributor Author

LVMBDV commented Oct 20, 2020

Oh so that's what that does, my bad. I'll fix the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants