Update user secret doesn't work

[ihannache]

Description

I have an existing minio user, when I try to update the secret for this user it's not working. the user still have the old password.

Steps to Reproduce

Create a new minio user :

resource "minio_iam_user" "test_user" {
   name = "test"
   secret = "test1234"
}

then update the ressource secret:

resource "minio_iam_user" "test_user" {
   name = "test"
   secret = "newPassword"
}

Terraform plan, apply shows the change:

Terraform will perform the following actions:

  # minio_iam_user.test_user will be updated in-place
  ~ resource "minio_iam_user" "test_user" {
        id            = "test"
        name          = "test"
      # Warning: this attribute value will no longer be marked as sensitive
      # after applying this change.
      ~ secret        = (sensitive value)
        # (4 unchanged attributes hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

Expected behavior:
login with new user:password --> test: newPassword

Actual behavior:
403 invalid login
I can't login with the new password, but the old password works, so the secret doesn't update
Reproduces how often:
100%

[ihannache]

The problem is here : https://github.com/aminueza/terraform-provider-minio/blob/master/minio/resource_minio_iam_user.go#L104

func minioUpdateUser(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {

	iamUserConfig := IAMUserConfig(d, meta)

	var err error
	secretKey := iamUserConfig.MinioSecret

	if secretKey == "" || iamUserConfig.MinioUpdateKey {
		if secretKey, err = generateSecretAccessKey(); err != nil {
			return NewResourceError("error creating user", d.Id(), err)
		}
	}

the fix :

func minioUpdateUser(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {

	iamUserConfig := IAMUserConfig(d, meta)

	var err error
	secretKey := iamUserConfig.MinioSecret

---> if secretKey == "" {
		if secretKey, err = generateSecretAccessKey(); err != nil {
			return NewResourceError("error creating user", d.Id(), err)
		}
	}

[ihannache]

You generate a new secret when the string is empty, but you don't have to generate one when the client updates the user secret.

[BuJo]

Let's hope with the latest round of fixes that this problem is gone. I've released v1.12.0