fix(validation): Be able to take in and validate null object event/us…

…er properties
amplitude · Nov 11, 2020 · 1ed41a3 · 1ed41a3
1 parent 77a01ee
commit 1ed41a3
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/src/utils.js b/src/utils.js
@@ -69,7 +69,7 @@ var truncate = function truncate(value) {
     }
   } else if (type(value) === 'object') {
     for (var key in value) {
-      if (value.hasOwnProperty(key)) {
+      if (key in value) {
         value[key] = truncate(value[key]);
       }
     }
@@ -110,7 +110,7 @@ var validateProperties = function validateProperties(properties) {
 
   var copy = {}; // create a copy with all of the valid properties
   for (var property in properties) {
-    if (!properties.hasOwnProperty(property)) {
+    if (!(property in properties)) {
       continue;
     }
 

diff --git a/test/utils.js b/test/utils.js
@@ -239,5 +239,19 @@ describe('utils', function() {
       }
       assert.deepEqual(utils.validateProperties(properties), {});
     });
+
+    it('should validate properties on null objects', function() {
+      var properties = Object.create(null);
+      properties['test'] = 'yes';
+      properties['key'] = 'value';
+      properties['15'] = '16';
+
+      var expected = {
+        'test': 'yes',
+        'key': 'value',
+        '15': '16'
+      };
+      assert.deepEqual(utils.validateProperties(properties), expected);
+    });
   });
 });